Jump to content

Module talk:Navbox/sandbox

Add topic
From Meta, a Wikimedia project coordination wiki
Latest comment: 2 years ago by Izno in topic Flatlist styles

Flatlist styles

[edit]

Hello @Izno,

I achieved merging, that seems OK, but I noticed `Flatlist/styles.css` is no more loaded. The comment says “navbar always has mini = 1, so here (on this wiki) we can assume that we don't need to output hlist styles in navbox again.”. However, Module:Navbar does not load Flatlist styles: they come from Common.css, even on en.wp. So, to fix the current visual issue with navbar, should I:

  • import Flatlist/styles.css from Module:Navbar?
  • import Flatlist/styles.css from Module:Nabox (removing if has_navbar() condition)?
  • only fix Common.css?

-- Pols12 (talk) 22:48, 19 August 2022 (UTC)Reply

Don't really understand why you imported from MediaWiki wiki again, should have just used the version that was here. Izno (talk) 22:53, 19 August 2022 (UTC)Reply
Because you point me the related diff… I’m perplexed. -- Pols12 (talk) 23:56, 19 August 2022 (UTC)Reply
See the original comment I made: the improvement was already here. Izno (talk) 00:03, 20 August 2022 (UTC)Reply
… but not with the same code. Maintaining a different version on each wiki is an arduous journey. No matter, that’s now fixed, thank you for your help. -- Pols12 (talk) 00:53, 20 August 2022 (UTC)Reply
Pols12 Different code that I did not make different. You can see the page history on the point. Izno (talk) 21:24, 21 August 2022 (UTC)Reply