Module talk:Navbox
Add topicAppearance
Latest comment: 1 year ago by MarcoAurelio in topic Update for internationalization purpose
Update for internationalization purpose
[edit]This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please update Module:Navbox with its /sandbox content. Updates come from English Wikipedia and were authored by Izno. The main purpose here is to use TemplateStyles flipping feature to improve readability of navboxes in right-to-left languages (issue reported on my talk page). -- Pols12 (talk) 01:11, 20 August 2022 (UTC)
- @Izno: this has been lingering here for a while, I expect because noone wants to risk breaking anything that is this transcluded, included in many of translation/translated pages. Any feedback on this? @Pols12: can you point to pages that are broken that require this change? — xaosflux Talk 15:20, 13 January 2023 (UTC)
- @Xaosflux, the change of interest shouldn't cause any issues.
- MediaWiki:Common.css will have duplicate styles after implementing this change. Based on a not-quite-cursory search, those should be removed after the job queue has had time to process the 34k pages using the module, so maybe a week's worth of time. That would be lines 393 to 460 and 482 to 494. Izno (talk) 19:03, 13 January 2023 (UTC)
- All navboxes translated in RTL languages have this issue. Please look at Deoband_Community_Wikimedia/ar, the navbox in the bottom: groups label are on the right, whereas group content is wrongly on the left. -- Pols12 (talk) 19:17, 13 January 2023 (UTC)
- @Izno, Pols12 and Xaosflux: Any updates about this request? Can it move forward? Any LTR/RTL issues that need to be addressed first? and is the code in the sandbox still valid or it needs another update? Thanks, —MarcoAurelio (talk) 18:17, 8 March 2023 (UTC)
- @MarcoAurelio I've mostly be ignoring this, I don't have any specific objections. — xaosflux Talk 18:36, 8 March 2023 (UTC)
- @Izno, Pols12 and Xaosflux: Any updates about this request? Can it move forward? Any LTR/RTL issues that need to be addressed first? and is the code in the sandbox still valid or it needs another update? Thanks, —MarcoAurelio (talk) 18:17, 8 March 2023 (UTC)
- @Pols12 and others, if I had a suggestion, it would be to pull on English Wikipedia's copy, perhaps with a change to account for the specific page name of the TemplateStyles for hlist, rather than the August 2022 version on meta, and then make any adjustments. I made the list styles improvement to en.wp's version in December, and also made a solution to how MobileFrontend will disappear styles. Izno (talk) 23:15, 8 March 2023 (UTC)
- I was reviewing thoses changes; I have integrated them, thank you @Izno. The local sandbox is now in sync with en.wp current module.
- I have created a local basic testcase, to ensure we would not meet any major issue while upgrading. It also lets see this fixes the issue with RTL languages. We still need a local update @MarcoAurelio please. --Pols12 (talk) 00:15, 9 March 2023 (UTC)
- @MarcoAurelio yup, I think we're good to pull here, just skimming. Izno (talk) 06:17, 11 March 2023 (UTC)
- @Izno, Pols12: The tests look good to me. I'll sync. I'll keep an eye too but I'd appreciate if you let me know if something goes south so we can revert. —MarcoAurelio (talk) 20:44, 11 March 2023 (UTC)
- @MarcoAurelio yup, I think we're good to pull here, just skimming. Izno (talk) 06:17, 11 March 2023 (UTC)
- Done. I checked few pages and everything seems working fine. —MarcoAurelio (talk) 20:57, 11 March 2023 (UTC)