Toolhub/Progress reports/2021-04-16

Toolhub

• User manual
• About
• Reports
  • Decision record
  • Progress reports
• Feedback

← week ending 2021-04-09

Toolhub progress reports week ending 2021-04-16

week ending 2021-04-23 →

Report on activities in the Toolhub project for the week ending 2021-04-16.

Diff improvements

Last week we merged the frontend code to display diffs between toolinfo record revisions. Having the visual display for the diff functionality made it obvious that several things were causing us to see "dirty" changes between revisions that were caused by our tooling rather than the author's intended data changes. We think this has been solved with a series of small changes:

• gerrit:678114 cleanup: Move BlankAsNull*Field to toolhub.fields
• phab:T278657 gerrit:678681 toolinfo: ignore empty objects in url_multilingual collections
• phab:T279484 Exclude modified_date from toolinfo.json diffs
• phab:T278657 gerrit:678681 toolinfo: ignore empty objects in url_multilingual collections
• phab:T277231 gerrit:678682 api: Add support for forcing empty strings to be saved as null
• gerrit:678684 ui: clean toolinfo data before submitting new/update
• gerrit:678683 api: Run toolinfo creation/update through normalization

We also made a few changes to improve the visual display of the diff and simplify the ui code:

• gerrit:678680 ui: rename i18n message "sourcerepository" to "repository"
• phab:T279740 [enhancement] Diff should omit headers on sequential changes to the same collection field
• gerrit:679419 ui: code cleanups in CrawlerHistory.vue

Language code validation added to backend

Tracked in Phabricator:
Task T278403 resolved

We have added new validation and data cleaning to the backend for the language codes that are used by many toolinfo fields to indicate the natural language that is in use. We ended up doing this by making a python client for consuming the language-data library that we have been using with the frontend layer for several months.

Code cleanups & annoyance fixes

• gerrit:678404 ui: Add missing / to crawler run urls url
• gerrit:678405 ui: fix default sort order display
• phab:T276186 Rely on notify plugin for alerts
• phab:T276187 Rely on function `makeApiCall` for API calls
• phab:T279739 [enhancement] Hitting enter on "edit summary" dialog should submit the form
• phab:T279735 gerrit:678433 ui: Update Home.vue back button handling
• phab:T278275 gerrit:678434 ui: Replace v-chip-group with plain div
• phab:T268774 gerrit:679039 Use `getFailurePayload` to retrieve error details in `createTool` method
• gerrit:679080 Initialize language data with current locale
• phab:T280074 Modify `/api/crawler/runs/` to output urls count information in `results` array
• phab:T279804 phab:T280278 security: Add Google FloC out-out header to responses

Wrap up

Lots and lots of code cleanup and annoyance fixing fun happened this week! Now it is time to get back to building more core features from our roadmap. Bryan expects to be working on backend enhancements related to our content moderation goals in the coming week. Srishti will keep working on improving test coverage and small bug fixes in the frontend until there is new backend functionality to expose.