Module talk:Citation/CS1

PMC validation

(copied from Help talk:CS1 errors)

As a recent PMCID can now exceed 5000000, the current validation check in Module:Citation/CS1 can erroneously flag genuine ids.

Example: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5095368/

• O’Neill, Kieran; Rai, Vivek; Kilpatrick, Alastair M (1 August 2017). "The International Society for Computational Biology and WikiProject Computational Biology: celebrating 10 years of collaboration towards open access". Bioinformatics 33 (15): 2429–2430. ISSN 1367-4803. PMC 5860125. PMID 28633433. doi:10.1093/bioinformatics/btx388. 

To fix this, it is necessary to change line 1011 which currently reads:

local test_limit = 5000000

to some number which is larger than the largest PMCID that may be anticipated in the near future. --RexxS (talk) 17:24, 24 April 2018 (UTC)

Hmmm, where did you read this? the test limit is already set to 30 millions, not 5 millions ! verdy_p (talk) 21:03, 24 April 2018 (UTC)

Sorry I confused PMID (limit to 30 millions) and PMC (limit set to 5 millions, increased now to 6 millions).... you're correct, but this is documented ! verdy_p (talk) 21:05, 24 April 2018 (UTC)

Internationalisation

Hi!

I have tried to internationalize this module. Can you review my proposed edits? Localization would happen in Configuration subpage Any feedback is welcome! --Pols12 (talk) 19:36, 7 July 2020 (UTC) This is not correct, as there's no text at all for the indexing on the language.; there would be lot of cases where the language has no translation. You need a fallback mechanism. verdy_p (talk) 18:17, 8 July 2020 (UTC)